Skip to content

Conversation

@zaoral
Copy link
Contributor

@zaoral zaoral commented Jan 6, 2026

  • hide private key not used
  • save filename when loading certificate

Copilot AI review requested due to automatic review settings January 6, 2026 23:56
@roboadhoc
Copy link
Contributor

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR mejora la experiencia de usuario (UX) del manejo de certificados para la localización uruguaya. Los cambios incluyen ocultar el campo de clave privada (public_key_id) para certificados de Uruguay y preservar el nombre del archivo al cargar certificados.

  • Agrega el campo content_filename para almacenar el nombre del archivo del certificado
  • Oculta el campo public_key_id cuando el certificado es de Uruguay
  • Incrementa la versión del módulo de 1.1.0 a 1.2.0

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
l10n_uy_ux/models/certificate_certificate.py Agrega el campo content_filename para almacenar el nombre del archivo del certificado
l10n_uy_ux/views/certificate_certificate_view.xml Hereda la vista del certificado para conectar el campo content_filename con el widget de archivo y ocultar public_key_id para certificados uruguayos
l10n_uy_ux/manifest.py Incrementa la versión a 19.0.1.2.0 y registra el nuevo archivo de vista en la lista de datos

* hide private key not used fir UY certiciate
* save filename and ext when loading certificate
@jjscarafia
Copy link
Member

@roboadhoc r+

roboadhoc pushed a commit to ingadhoc/odoo-argentina-ee that referenced this pull request Jan 12, 2026
* Link certificate and private key directly when creating a new
  certificate, avoiding problem on clean up of the p key.
* Disable create option and only leave create and edit available
* Store certificate name: we store the certificate name and ext. better
  to identify the uploaded file and better to manage the file if we need
  to download it
* hide not used fields: public key, certificate password and scope
  selection field

Part-of: #867
Related: ingadhoc/uruguay#382
Signed-off-by: Juan José Scarafía <[email protected]>
roboadhoc pushed a commit to ingadhoc/odoo-argentina-ee that referenced this pull request Jan 12, 2026
Should not copy if we duplicate the electronic move (invoice, debit
and credit notes). the value will be empty

closes #867

Related: ingadhoc/uruguay#382
Signed-off-by: Juan José Scarafía <[email protected]>
@roboadhoc roboadhoc closed this in f1c03b3 Jan 12, 2026
@roboadhoc roboadhoc added the 18.1 label Jan 12, 2026
@roboadhoc roboadhoc deleted the 19.0-t-62117-kz branch January 12, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants